Check in field visibility transformer test - union member error now fixed - #4275
Merged
dondonz merged 3 commits intoMar 4, 2026
Merged
Check in field visibility transformer test - union member error now fixed#4275dondonz merged 3 commits into
dondonz merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Test Results 336 files ±0 336 suites ±0 5m 12s ⏱️ +2s Results for commit c48c88c. ± Comparison against base commit 5273839. This pull request removes 154 and adds 131 tests. Note that renamed tests count towards both. ?
, expected: combo-\"\\\b\f\n\r\t, #4]
__schema { types { fields { args { type { name fields { name }}}}}}
__schema { types { fields { type { name fields { name }}}}}
__schema { types { inputFields { type { inputFields { name }}}}}
__schema { types { interfaces { fields { type { interfaces { name } } } } } }
__schema { types { name} }
__type(name : "t") { name }
a1: __schema { types { name} }
a1: __type(name : "t") { name }
…
graphql.ScalarsBooleanTest ‑ parseValue throws exception for invalid input <java.lang.Object@38a5497e> graphql.ScalarsBooleanTest ‑ serialize throws exception for invalid input <java.lang.Object@7930e73d> graphql.ScalarsIDTest ‑ parseValue allows any object via String.valueOf <java.lang.Object@367b4c7> graphql.ScalarsIDTest ‑ serialize allows any object via String.valueOf <java.lang.Object@6c472a75> graphql.ScalarsIntTest ‑ parseValue throws exception for invalid input <java.lang.Object@2030d990> graphql.ScalarsIntTest ‑ serialize throws exception for invalid input <java.lang.Object@1b45621b> graphql.execution.instrumentation.TracingInstrumentationTest ‑ do not trace introspection information [testExecutionStrategy: <graphql.execution.AsyncExecutionStrategy@250870ff fieldCollector=inaccessible executionStepInfoFactory=inaccessible dataFetcherExceptionHandler=inaccessible resolvedType=inaccessible>, #0] graphql.execution.instrumentation.TracingInstrumentationTest ‑ do not trace introspection information [testExecutionStrategy: <graphql.execution.AsyncSerialExecutionStrategy@72db65cb fieldCollector=inaccessible executionStepInfoFactory=inaccessible dataFetcherExceptionHandler=inaccessible resolvedType=inaccessible>, #1] graphql.execution.instrumentation.TracingInstrumentationTest ‑ tracing captures timings as expected [testExecutionStrategy: <graphql.execution.AsyncExecutionStrategy@4f284708 fieldCollector=inaccessible executionStepInfoFactory=inaccessible dataFetcherExceptionHandler=inaccessible resolvedType=inaccessible>, #0] graphql.execution.instrumentation.TracingInstrumentationTest ‑ tracing captures timings as expected [testExecutionStrategy: <graphql.execution.AsyncSerialExecutionStrategy@48ce43e4 fieldCollector=inaccessible executionStepInfoFactory=inaccessible dataFetcherExceptionHandler=inaccessible resolvedType=inaccessible>, #1] … ♻️ This comment has been updated with latest results. |
Sorry, something went wrong.
dondonz
marked this pull request as draft
March 1, 2026 19:35
Copy link
Copy Markdown
Member
Author
|
Checked out against a copy of the field visibility transformer prior to the fixes (in April 2025) and confirmed the test was failing on the old version. |
Sorry, something went wrong.
dondonz
marked this pull request as ready for review
March 1, 2026 20:17
andimarek
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the large refactor of the field visibility transformer, this issue is now also fixed #4185
For completeness I'm checking in a test with the original bug reported at work, with anonymised schema element names