FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Simplify operation validation traversal context by andimarek · Pull Request #4434 · graphql-java/graphql-java · GitHub

Simplify operation validation traversal context - #4434

Merged
andimarek merged 1 commit into
masterfrom
codex/simplify-validation-context
Aug 5, 2026
Merged

Simplify operation validation traversal context#4434
andimarek merged 1 commit into
masterfrom
codex/simplify-validation-context

Conversation

Copy link
Copy Markdown
Member

Summary

  • remove the standalone TraversalContext and traversal forwarding methods from ValidationContext
  • keep validation traversal state directly in OperationValidator and resolve output types from their AST owners
  • track the current operation directly, including during fragment retraversal
  • replace stack-mechanics tests with behavioral coverage for roots, fragments, query paths, nested inputs, directives, and unresolved arguments

Testing

  • ./gradlew test testng jacocoTestReport (5,927 tests)
  • ./gradlew check -x test -x testng
  • local CI-equivalent coverage comparison reports no per-class regressions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Test Report

Test Results

Java Version Total Passed Failed Errors Skipped
Java 11 5927 (-7 🔴) 5871 (-7 🔴) 0 (±0) 0 (±0) 56 (±0)
Java 17 5927 (-7 🔴) 5870 (-7 🔴) 0 (±0) 0 (±0) 57 (±0)
Java 21 5927 (-7 🔴) 5870 (-7 🔴) 0 (±0) 0 (±0) 57 (±0)
Java 25 5927 (-7 🔴) 5870 (-7 🔴) 0 (±0) 0 (±0) 57 (±0)
jcstress 32 (±0) 32 (±0) 0 (±0) 0 (±0) 0 (±0)
Total 23740 (-28 🔴) 23513 (-28 🔴) 0 (±0) 0 (±0) 227 (±0)

Code Coverage (Java 25)

Metric Covered Missed Coverage vs Master
Lines 30046 3121 90.6% ±0.0%
Branches 8785 1519 85.3% +0.1% 🟢
Methods 8026 1206 86.9% ±0.0%

Changed Class Coverage (4 classes)

Class Line Branch Method
g.v.OperationValidator +0.3% 🟢 +1.2% 🟢 +0.1% 🟢
g.v.TraversalContext removed removed removed
g.v.ValidationContext +2.8% 🟢 ±0.0% +5.0% 🟢
g.v.ValidationError
$Builder
±0.0% +50.0% 🟢 ±0.0%

Full HTML report: build artifact jacoco-html-report

Updated: 2026-08-05 11:23:25 UTC

andimarek merged commit bc41471 into master Aug 5, 2026
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL