FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

README: fix apollo-client link by sduthil · Pull Request #78 · graphql-python/flask-graphql · GitHub

README: fix apollo-client link - #78

Open
sduthil wants to merge 1 commit into
graphql-python:masterfrom
sduthil:readme-apollo-client-link
Open

README: fix apollo-client link#78
sduthil wants to merge 1 commit into
graphql-python:masterfrom
sduthil:readme-apollo-client-link

Conversation

sduthil commented Apr 9, 2020

Copy link
Copy Markdown

No description provided.

coveralls commented Apr 9, 2020
edited
Loading

Copy link
Copy Markdown

Coverage remained the same at 93.548% when pulling 442b8b3 on sduthil:readme-apollo-client-link into 9691baf on graphql-python:master.

Copy link
Copy Markdown

Coverage remained the same at 93.548% when pulling 88ae942 on sduthil:readme-apollo-client-link into 9691baf on graphql-python:master.

Comment thread README.md Outdated

Copy link
Copy Markdown
Contributor

In fact, the Apollo Client isn't only limited to React as there is one for Angular too and so on.

If you check the docs, you will see that it points to another guide at the following link for:

I think the first one is more generalized and not bound to a specific frontend framework.

Cheers!

sduthil force-pushed the readme-apollo-client-link branch from 88ae942 to 442b8b3 Compare April 14, 2020 13:01

sduthil commented Apr 14, 2020

Copy link
Copy Markdown
Author

In fact, the Apollo Client isn't only limited to React as there is one for Angular too and so on.

If you check the docs, you will see that it points to another guide at the following link for:

* React: [batch-http](https://www.apollographql.com/docs/link/links/batch-http/)

* Angular: [angular-link-http-batch](https://github.com/apollographql/apollo-angular/tree/master/packages/apollo-angular-link-http-batch)

I think the first one is more generalized and not bound to a specific frontend framework.

Agreed that the doc should be as frontend-agnostic as possible. But IMHO the paragraph about query batching in the React section:

  • does not mention React
  • links to the detailed, agnostic documentation
  • gives a good example of using query batching, which I found very useful while learning GraphQL

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL