Merge aiohttp-graphql - #42
Merged
KingDarBoja merged 2 commits intoJun 10, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jkimbo
previously approved these changes
Jun 6, 2020
jkimbo
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good. There is definitely lots of code that could be shared between the different framework implementations but this is good for now.
Sorry, something went wrong.
KingDarBoja
force-pushed
the
merge-aiohttp-graphql
branch
from
d36c024 to
3b9dc2f
Compare
June 6, 2020 17:03
jkimbo
approved these changes
Jun 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Assignees
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #34, this PR merges aiohttp-graphql library into graphql-server-core.
To install the integration with aiohttp, run the below command on your terminal.
pip install graphql-server-core[aiohttp].
This should be rebased after #38 gets merged in order to solve the failing tests at graphql-server-core files.