Add graphiql options and missing flask context - #55
Merged
KingDarBoja merged 4 commits intoJul 27, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
After reading a bit regarding what context is used for, I submitted another commit with a possible test suite to ensure and help others to understand the proper functionality of context using Flask as example. |
Sorry, something went wrong.
jkimbo
requested changes
Jul 12, 2020
jkimbo
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Some left over print statements need to be removed but otherwise looks good.
Sorry, something went wrong.
Comment thread
tests/flask/test_graphqlview.py
Outdated
jkimbo
approved these changes
Jul 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add support for graphiql options like as:
Also, add the missing context attribute as requested at this old flask-graphql#52 issue.
However, the approach I used for all 4 servers (flask, aiohttp, webob, sanic) was based on this sanic#8 issue which was solved at this pull request.
There are other related issues as well on each server integrations:
As far as I know, this context will be passed to the execute method on GraphQL, which will be passed to all resolve functions as stated on GraphQL-JS docs. At the end, this will be part of the GraphQLResolveInfo, which is used by resolve_field_value_or_error to resolve the field.
Based on that, I am not 100% sure if it the correct way of handling custom context for all server integrations so any suggestion is welcome!