add support for validation rules - #83
Merged
jkimbo merged 5 commits intoAug 10, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
(commited by mistake. updated .gitignore)
Copy link
Copy Markdown
Contributor
Author
|
oops, committed venv by mistake. Updated .gitignore and removed the dir. |
Sorry, something went wrong.
jkimbo
reviewed
Aug 9, 2021
Comment thread
graphql_server/aiohttp/graphqlview.py
| return self.middleware | ||
|
|
||
| def get_validation_rules(self): | ||
| return self.validation_rules |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This should return the default validation rules if validation_rules is None:
from graphql import specified_rules
Sorry, something went wrong.
jkimbo
previously approved these changes
Aug 9, 2021
Copy link
Copy Markdown
Contributor
Author
|
When would this be merged?🤔 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@CodeByAryan I just merged #84 Could you bring this branch up to date? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allows passing validation rules as an argument to the graphqlview.
also updated docs regarding the same. fixes #82