FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update dependencies by kiendang · Pull Request #99 · graphql-python/graphql-server · GitHub

/ graphql-server Public

Update dependencies - #99

Merged
erikwrede merged 15 commits into
graphql-python:masterfrom
kiendang:update-dependencies
Dec 25, 2022
ConversationCommits (15)ChecksFiles changed
Merged

Update dependencies#99
erikwrede merged 15 commits into
graphql-python:masterfrom
kiendang:update-dependencies

Conversation

kiendang commented Dec 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Update dependencies so that the package works with the latest framework versions in preparation for a stable v3 release. See #96 for context.

The PR's been rebased for convenient commit by commit review.

From sanic v21 view now requires defining the method get, post, ... independently otherwise will throw 405, thus the current approach of overriding dispatch_request won't work. The workaround is to just assign the individual method to dispatch_request

async def __handle_request(self, request, ...): ... # previously dispatch_request

get = post = put = head = options = patch = delete = __handle_request

Close #86
Close #92
Close #94
Close #98

Supersede #87, #89, #91, #95.

@erikwrede

kiendang force-pushed the update-dependencies branch 8 times, most recently from 2e064b3 to 7956f6e Compare December 21, 2022 15:51
kiendang force-pushed the update-dependencies branch from 7956f6e to 53b569b Compare December 25, 2022 05:12
gcampax and others added 4 commits December 25, 2022 13:15
kiendang force-pushed the update-dependencies branch from 53b569b to 730c796 Compare December 25, 2022 05:16
Update sanic to v22.6
80d3f7c
Make sanic v22.9 work
271b447
Fix deprecation warnings
aac23bc 
DeprecationWarning: Use 'content=<...>' to upload raw bytes/text content.
Update graphiql to 1.4.7 for security reason
6623379 
"All versions of graphiql < 1.4.7 are vulnerable to an XSS attack."
https://github.com/graphql/graphiql/blob/ab2b52f06213bd9bf90c905c1b460b6939f3d856/docs/security/2021-introspection-schema-xss.md
Fix webob graphiql check
68ff98d 
Was working by accident before
Fix quart PytestCollectionWarning
d1d8835 
cannot collect test class 'TestClientProtocol' because it has a __init__ constructor
kiendang force-pushed the update-dependencies branch from 730c796 to d1d8835 Compare December 25, 2022 05:22
erikwrede reviewed Dec 25, 2022
View reviewed changes

erikwrede left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Great Job! The minimum version changes look reasonable, given the long time this library has been resting dormant.

Please see my comments attached below.

Comment thread setup.py Outdated
install_requires = ["graphql-core>=3.2,<3.3", "typing-extensions>=4,<5"]
install_requires = [
"graphql-core>=3.2,<3.3",
"Jinja2>=3.1,<4",

erikwrede Dec 22, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why is jinja now a required dependency? AFAIK it's only used for GraphiQL, which users can disable.

kiendang Dec 25, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yup you're right. Just moved it back to test dependencies.

Comment thread graphql_server/render_graphiql.py
Comment on lines 9 to 11

GRAPHIQL_VERSION = "1.0.3"
GRAPHIQL_VERSION = "1.4.7"

erikwrede Dec 25, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Any reason to not update to 2.2.0 straight away?

kiendang Dec 25, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We definitely should upgrade to 2.2.0. I was basing this on https://github.com/graphql/express-graphql/blob/main/src/renderGraphiQL.ts plus the graphiql readme recommending upgrading to 1.4.7 so I was under the impression that 1.4.7 is the latest version. Will try upgrading to 2.2.0 and verifying that everything's working, but maybe we should merge this first and I'll submit a subsequent PR for that?

erikwrede Dec 25, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sounds good!

kiendang commented Dec 25, 2022

Copy link
Copy Markdown
Contributor Author

Push a few more commits to add python 3.11 and remove 3.6 (EOL) which I suspect is what makes the tests fail.

kiendang force-pushed the update-dependencies branch from ea3a4da to f292a7b Compare December 25, 2022 17:42
kiendang force-pushed the update-dependencies branch from f292a7b to ff2d087 Compare December 25, 2022 17:50
erikwrede merged commit 184ba72 into graphql-python:master Dec 25, 2022
This was referenced Dec 25, 2022
Closed
Closed
Closed
Closed
kiendang deleted the update-dependencies branch December 26, 2022 03:03
dctalbot mentioned this pull request Feb 8, 2023
Closed
andrewtruong pushed a commit to wandb/weave that referenced this pull request Jul 9, 2026
fix(backend): replace dannygoldstein/graphql-server fork with upstrea…
c17f9cd 
…m v3.0.0 (#45831)

## Description

Replace the pinned `dannygoldstein/graphql-server` fork with the
official upstream `graphql-server[flask]>=3.0.0` from PyPI.

The fork was a workaround for
[graphql-python/graphql-server#98](graphql-python/graphql-server#98),
which has since been resolved (via [PR
#99](graphql-python/graphql-server#99)). The
upstream package received a stable 3.0.0 release on 2025-08-17.

This only affects test dependencies (`requirements.test.txt`), not
production code.

## Testing

- [ ] CI passes with the upstream package (weave-python tests install
and run against the official release)


Link to Devin session:
https://app.devin.ai/sessions/12314a9b91584f3281223bf90e11cd0b
Requested by: @blalor

---------

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

erikwrede erikwrede approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

4 participants

Back | FazBrowse Home | New Git URL