FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

xds: remove ORCA LRS propagation flag by Zhengcy05 · Pull Request #12842 · grpc/grpc-java · GitHub

/ grpc-java Public

xds: remove ORCA LRS propagation flag - #12842

Open
Zhengcy05 wants to merge 2 commits into
grpc:masterfrom
Zhengcy05:cleanup/remove-orca-lrs-flag
ConversationCommits (2)ChecksFiles changed
Open

xds: remove ORCA LRS propagation flag#12842
Zhengcy05 wants to merge 2 commits into
grpc:masterfrom
Zhengcy05:cleanup/remove-orca-lrs-flag

Conversation

Zhengcy05 commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Summary

Remove GRPC_EXPERIMENTAL_XDS_ORCA_LRS_PROPAGATION, which became redundant after ORCA-to-LRS propagation was enabled by default.

Changes

  • Delete the static flag and its conditional branch in LoadStatsManager2.
  • Always parse lrs_report_endpoint_metrics into BackendMetricPropagation in CDS parsing.
  • Always record ORCA top-level metrics in the LRS listener.
  • Update tests to reflect the always-on behavior and remove flag-toggling test code.

Testing

  • ./gradlew -PskipAndroid=true -PskipCodegen=true :grpc-xds:test --tests io.grpc.xds.client.LoadStatsManager2Test --tests io.grpc.xds.ClusterImplLoadBalancerTest --tests io.grpc.xds.GrpcXdsClientImplDataTest --tests io.grpc.xds.ClusterResolverLoadBalancerTest

Closes #12837

linux-foundation-easycla Bot commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown


The committers listed above are authorized under a signed CLA.

  • ✅ login: Zhengcy05 / name: Zhengcy05 (cd8c843)

shivaspeaks self-requested a review June 7, 2026 17:43

kannanjgithub commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

We wanted to wait for a few weeks with the flag enabled by default, to confirm there are no problems observed in internal testing, before removing the flag.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

shivaspeaks Awaiting requested review from shivaspeaks

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clean up the flag GRPC_EXPERIMENTAL_XDS_ORCA_LRS_PROPAGATION

2 participants

Back | FazBrowse Home | New Git URL