CKEditor5 has no global registry of editor instances and the current script used for setting WYSIWYG field's value no longer works if CKEditor5 is utilised. This leads to failing tests (i.e., when comparing the actual value with the expected one after filling out a WYSIWYG field)
Proposed change:
Enable filling CKEditor5 based fields while keeping backwards compatibility with CKEditor4 (and below) if needed.
The proposed solution checks if there is data-ckeditor5-id attribute present for the WYSIWYG field. If so, original script is overridden with CKEditor5 compatible version (see https://ckeditor.com/docs/ckeditor5/latest/examples/how-tos.html#how-to-get-the-editor-instance-object-from-the-dom-element). Therefore, we don't need any additional parameters of functions to handle CKEditor5 specifically as the existing one can decide itself which version of CKEditor is in use for the particular field and act accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Proposed change: