FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Changed instances of staff to admin by printharsh · Pull Request #616 · hackmcgill/hackerAPI · GitHub

Changed instances of staff to admin - #616

Open
printharsh wants to merge 1 commit into
developfrom
refactor/staffToAdmin
Open

Changed instances of staff to admin#616
printharsh wants to merge 1 commit into
developfrom
refactor/staffToAdmin

Conversation

printharsh commented Dec 14, 2019
edited
Loading

Copy link
Copy Markdown

Tickets:

List of changes:

Changed instances of staff to admin.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Ran npm run test.

Questions for code reviewers?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

loreina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm!! 🥇

pierreTklein left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL