fix: preserve note permission flags - #107
Open
EastSun5566 wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull request overview
Fixes a CLI flag-parsing bug where --readPermission and --writePermission could overwrite each other due to sharing the same Oclif flag definition object, causing readPermission to be dropped in requests.
Changes:
- Converts notePermission into a factory (notePermission()) so each permission flag gets a distinct flag definition object.
- Updates notes and team-notes create/update commands to use notePermission() for both readPermission and writePermission.
- Adds a unit test verifying both permissions are preserved (and that a lone readPermission stays mapped correctly).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file| File | Description |
|---|---|
| src/flags.ts | Changes notePermission from a shared flag object to a factory to avoid parser overwrite. |
| src/commands/notes/create.ts | Uses distinct flag definitions for readPermission/writePermission via notePermission(). |
| src/commands/notes/update.ts | Uses distinct flag definitions for readPermission/writePermission via notePermission(). |
| src/commands/team-notes/create.ts | Uses distinct flag definitions for readPermission/writePermission via notePermission(). |
| src/commands/team-notes/update.ts | Uses distinct flag definitions for readPermission/writePermission via notePermission(). |
| test/note-permission-flags.test.ts | Adds parsing tests to prevent regressions for create/update across personal/team notes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Sorry, something went wrong.
Comment thread
src/flags.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #106
Create separate flag definitions for readPermission and writePermission so their values don’t overwrite each other.