Release v1.3.0 - #26
Merged
thomas-jakemeyn merged 8 commits intoMay 14, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…he browser without dynamically importing electron
…f maintaining them manually
bigorn0
commented
May 13, 2025
Comment thread
test/resources/app-electron/renderer.js
bigorn0
commented
May 13, 2025
Comment thread
package.json
Outdated
| "build:esm": "swc ./src -d ./dist/esm --ignore **/*.d.ts --strip-leading-paths -C module.type=es6 -C module.ignoreDynamic=true", | ||
| "build:cjs": "swc ./src -d ./dist/cjs --ignore **/*.d.ts --strip-leading-paths -C module.type=commonjs -C module.ignoreDynamic=true", | ||
| "build": "npm run build:cjs && npm run build:esm && npm run build:esm:package", | ||
| "build:esm": "npx esbuild ./src/index.ts --bundle --format=esm --tree-shaking=true --minify --outdir=./dist/esm --format=esm --platform=node --define:BROWSER_BUILD=false --external:electron", |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Maybe at this stage having an esbuild config might be a good idea...
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
What about defining a NPM script with all common parameters? Something like this:
"esbuild": "npx esbuild ./src/index.ts --bundle --tree-shaking=true --minify --external:electron", "build:esm": "npm run esbuild -- --format=esm --outdir=./dist/esm --define:BROWSER_BUILD=false", "build:cjs": "npm run esbuild -- --format=cjs --outdir=./dist/cjs --define:BROWSER_BUILD=false", "build:browser": "npm run esbuild -- --format=esm --outdir=./dist/browser --define:BROWSER_BUILD=true",
Sorry, something went wrong.
bigorn0
commented
May 13, 2025
Comment thread
src/hckFetch.ts
bigorn0
marked this pull request as ready for review
May 13, 2025 10:51
thomas-jakemeyn
requested changes
May 14, 2025
Comment thread
package.json
Outdated
Comment thread
package.json
Outdated
| "build:esm": "swc ./src -d ./dist/esm --ignore **/*.d.ts --strip-leading-paths -C module.type=es6 -C module.ignoreDynamic=true", | ||
| "build:cjs": "swc ./src -d ./dist/cjs --ignore **/*.d.ts --strip-leading-paths -C module.type=commonjs -C module.ignoreDynamic=true", | ||
| "build": "npm run build:cjs && npm run build:esm && npm run build:esm:package", | ||
| "build:esm": "npx esbuild ./src/index.ts --bundle --format=esm --tree-shaking=true --minify --outdir=./dist/esm --format=esm --platform=node --define:BROWSER_BUILD=false --external:electron", |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
What about defining a NPM script with all common parameters? Something like this:
"esbuild": "npx esbuild ./src/index.ts --bundle --tree-shaking=true --minify --external:electron", "build:esm": "npm run esbuild -- --format=esm --outdir=./dist/esm --define:BROWSER_BUILD=false", "build:cjs": "npm run esbuild -- --format=cjs --outdir=./dist/cjs --define:BROWSER_BUILD=false", "build:browser": "npm run esbuild -- --format=esm --outdir=./dist/browser --define:BROWSER_BUILD=true",
Sorry, something went wrong.
Comment thread
package.json
Outdated
| "build:cjs": "swc ./src -d ./dist/cjs --ignore **/*.d.ts --strip-leading-paths -C module.type=commonjs -C module.ignoreDynamic=true", | ||
| "build": "npm run build:cjs && npm run build:esm && npm run build:esm:package", | ||
| "esbuild": "npx esbuild ./src/index.ts --bundle --tree-shaking=true --minify --external:electron", | ||
| "build:esm": "npm run esbuild -- --format=esm --outdir=./dist/esm --format=esm --platform=node --define:BROWSER_BUILD=false", |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Suggested change
| "build:esm": "npm run esbuild -- --format=esm --outdir=./dist/esm --format=esm --platform=node --define:BROWSER_BUILD=false", | |
| "build:esm": "npm run esbuild -- --format=esm --outdir=./dist/esm --platform=node --define:BROWSER_BUILD=false", |
Sorry, something went wrong.
Comment thread
package.json
Outdated
| "build": "npm run build:cjs && npm run build:esm && npm run build:esm:package", | ||
| "esbuild": "npx esbuild ./src/index.ts --bundle --tree-shaking=true --minify --external:electron", | ||
| "build:esm": "npm run esbuild -- --format=esm --outdir=./dist/esm --format=esm --platform=node --define:BROWSER_BUILD=false", | ||
| "build:cjs": "npm run esbuild -- --format=cjs --outdir=./dist/cjs --format=cjs --platform=node --define:BROWSER_BUILD=false", |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Suggested change
| "build:cjs": "npm run esbuild -- --format=cjs --outdir=./dist/cjs --format=cjs --platform=node --define:BROWSER_BUILD=false", | |
| "build:cjs": "npm run esbuild -- --format=cjs --outdir=./dist/cjs --platform=node --define:BROWSER_BUILD=false", |
Sorry, something went wrong.
thomas-jakemeyn
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
Fixed