Make `data` input to `_compose_parser` optional by bruno-f-cruz · Pull Request #46 · harp-tech/harp-python · GitHub

Fixes an issue where the inner callable from _compose_parser was not allowing the data input to be optional.

Lines 79 to 97 in 9d05b58

    
           def _compose_parser( 
        
               f: Callable[[DataFrame], DataFrame], 
        
               g: Callable[..., DataFrame], 
        
               params: _ReaderParams, 
        
           ) -> Callable[..., DataFrame]: 
        
               def parser( 
        
                   data, 
        
                   columns: Optional[Axes] = None, 
        
                   epoch: Optional[datetime] = params.epoch, 
        
                   keep_type: bool = params.keep_type, 
        
               ): 
        
                   df = g(data, columns, epoch, keep_type) 
        
                   result = f(df) 
        
                   type_col = df.get(MessageType.__name__) 
        
                   if type_col is not None: 
        
                       result[MessageType.__name__] = type_col 
        
                   return result 
        
               return parser

This allows g aka _create_register_reader to take care of the path inference logic

Closes #45

This allows `g` aka `_create_register_reader` to take care of the path inference logic

@glopesdev Some notes:

Not sure this is the best way to create the unit test, but it is the one I think reuses the assets in tests the most efficiently.
I ended up fixing a pyright test fail due to an internal import of a pandas type. I checked and I don't think that there is a way to avoid the import, so I just muted it. It may be worth generating a uv.lock file for this library as I think the problem likely stems from a recent upgrade to pyright.

bruno-f-cruz added 3 commits April 1, 2025 11:12

Make data input to _compose_parser optional

02059bf

This allows `g` aka `_create_register_reader` to take care of the path inference logic

Add unittest for registers with payload spec

6a882c2

Suppress pyright error on internal method import

3ee94ae

bruno-f-cruz requested a review from glopesdev April 1, 2025 21:34

bruno-f-cruz added the critical This is a blocking issue affecting all users label Apr 1, 2025

glopesdev approved these changes Apr 2, 2025

View reviewed changes

glopesdev merged commit f6f4c53 into main Apr 2, 2025

glopesdev added the fix Pull request that fixes an issue label Apr 2, 2025

glopesdev deleted the fix-parser branch April 2, 2025 16:07

Make `data` input to `_compose_parser` optional by bruno-f-cruz · Pull Request #46 · harp-tech/harp-python · GitHub

Uh oh!

Make data input to _compose_parser optional - #46

Make data input to _compose_parser optional#46
glopesdev merged 3 commits into
mainfrom
fix-parser

bruno-f-cruz commented Apr 1, 2025 •
edited
Loading

Uh oh!

Uh oh!

bruno-f-cruz commented Apr 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	def _compose_parser(
	f: Callable[[DataFrame], DataFrame],
	g: Callable[..., DataFrame],
	params: _ReaderParams,
	) -> Callable[..., DataFrame]:
	def parser(
	data,
	columns: Optional[Axes] = None,
	epoch: Optional[datetime] = params.epoch,
	keep_type: bool = params.keep_type,
	):
	df = g(data, columns, epoch, keep_type)
	result = f(df)
	type_col = df.get(MessageType.__name__)
	if type_col is not None:
	result[MessageType.__name__] = type_col
	return result

	return parser

Make `data` input to `_compose_parser` optional by bruno-f-cruz · Pull Request #46 · harp-tech/harp-python · GitHub

Uh oh!

Make data input to _compose_parser optional - #46

Make data input to _compose_parser optional#46glopesdev merged 3 commits intomainharp-tech/harp-python:mainfrom fix-parserharp-tech/harp-python:fix-parserCopy head branch name to clipboard

Conversation

bruno-f-cruz commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bruno-f-cruz commented Apr 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Make data input to _compose_parser optional#46
glopesdev merged 3 commits into
mainfrom
fix-parser

bruno-f-cruz commented Apr 1, 2025 •
edited
Loading