Favor yaml 1.1 spec via pyyaml package - #51
Draft
bruno-f-cruz wants to merge 2 commits into
Draft
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifiest the dependencies of this library by dropping pydantic-yaml. This has two advantages:
1- We now only rely on pydantic and pyyaml, two well supported and maintained pacakges
2- We support 1.1 by default. This is important as pyyaml officialy targets version 1.1 of the yaml spec. This is the version we have classically been using to make new devices.
It should be noted that this PR is blocked by harp-tech/protocol#159 and the respective reference to a new device.yml file. This should probably be done via submodule.