Add traffic endpoints. - #380
Open
ajmcmiddlin wants to merge 18 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Traffic API requires auth, so remove the functions that don't do auth. The ones you cargo culted from some other module when getting started...
phadej
suggested changes
Jun 3, 2019
Comment thread
src/GitHub/Data/Traffic.hs
Outdated
Comment thread
src/GitHub/Data/Traffic.hs
Outdated
Comment thread
src/GitHub/Endpoints/Repos/Traffic.hs
Comment thread
src/GitHub/Data/Traffic.hs
Outdated
Copy link
Copy Markdown
Author
|
@phadej, thanks for the quick feedback. I think I've addressed everything as requested. Let me know what you want me to change the example repo to if you want it changed. |
Sorry, something went wrong.
phadej
reviewed
Jun 4, 2019
Comment thread
src/GitHub/Endpoints/Repos/Traffic.hs
Outdated
Closed
Copy link
Copy Markdown
Author
|
@phadej I believe I've addressed the outstanding feedback. Let me know if I haven't. |
Sorry, something went wrong.
Copy link
Copy Markdown
❌ Base branch update has failedDetailsNo oauth valid tokens |
Sorry, something went wrong.
andreasabel
requested changes
Apr 19, 2022
andreasabel
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks @ajmcmiddlin for this contribution!
Can we have a testcase, or a demonstration in samples/?
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add endpoints from the traffic API.