FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Make hack files the default by lexidor · Pull Request #156 · hhvm/hack-codegen · GitHub

This repository was archived by the owner on Aug 25, 2025. It is now read-only.
/ hack-codegen Public archive

Make hack files the default - #156

Open
lexidor wants to merge 3 commits into
hhvm:mainfrom
lexidor:make-hack-files-the-default
Open

lexidor wants to merge 3 commits into
hhvm:mainfrom
lexidor:make-hack-files-the-default

Conversation

lexidor commented May 25, 2023

Copy link
Copy Markdown
Contributor

fixes #112

Fixes:

  • Files without a legacy extension .php, .hh, are treated as DOT_HACK.
  • Same goes for .hhi
  • Bumps minimum hhvm version to 4.153.

lexidor added 3 commits May 25, 2023 08:40
This is the first LTS with the, if not legacy then mode = .hack, change.
For users on older UNSUPPORTED versions of hhvm, we can't remove the sigils.

lexidor commented May 28, 2023

Copy link
Copy Markdown
Contributor Author

Fixes hhvm/hack-router-codegen#18

This branch has not been deployed

No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make .hack files the default in a future release

2 participants


Back | FazBrowse Home | New Git URL