FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add motion sensor setting to tplink by rytilahti · Pull Request #129393 · home-assistant/core · GitHub

  1. home-assistant
  2. core

Repository navigation

Add motion sensor setting to tplink - #129393

Merged
joostlek merged 5 commits into
devfrom
tplink/feat/pir_feature
Nov 6, 2024
ConversationCommits (5)ChecksFiles changed
Merged

Add motion sensor setting to tplink#129393
joostlek merged 5 commits into
devfrom
tplink/feat/pir_feature

Conversation

rytilahti commented Oct 29, 2024

Copy link
Copy Markdown
Member

Proposed change

This PR adds a new switch to control the motion detection sensor found on some dimmers.

Related upstream PR: python-kasa/python-kasa#1174

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

rytilahti requested a review from bdraco as a code owner October 29, 2024 08:52

home-assistant Bot commented Oct 29, 2024

Copy link
Copy Markdown
Contributor

Hey there @bdraco, @sdb9696, mind taking a look at this pull request as it has been labeled with an integration (tplink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tplink can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tplink Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

rytilahti mentioned this pull request Oct 29, 2024
Merged
rytilahti marked this pull request as draft October 29, 2024 08:54
rytilahti added the waiting-for-upstream We're waiting for a change upstream label Oct 29, 2024

rytilahti commented Nov 4, 2024

Copy link
Copy Markdown
Member Author

Required version bump shipped in #129817, so marking this as ready for review.

rytilahti marked this pull request as ready for review November 4, 2024 23:18
rytilahti removed the waiting-for-upstream We're waiting for a change upstream label Nov 4, 2024
joostlek reviewed Nov 5, 2024
View reviewed changes
Comment thread homeassistant/components/tplink/strings.json Outdated
Comment on lines +191 to +192
"pir_enabled": {
"name": "PIR enabled"

joostlek Nov 5, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It feels strange to call this PIR enabled, since it's not enabled, the switch decides if its enabled

CrazyCoder Nov 5, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

IMO, this is correct. The goal of this PR is to control the state of the motion sensor in the switch (enabled/disabled). This is a user setting, and the user decides if PIR should be enabled or disabled for the switch. You can control it from the Kasa app, and with this PR you can also control it via HA.

Here is how it looks in the Kasa app:

Instead of PIR enabled we can name it Motion Sensor for consistency. But I'm fine with any name.

rytilahti Nov 6, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fixed conflicts and renamed this to "Motion sensor". It is not consistent with some other X enabled switches, but it's more understandable than rather technical PIR so I think it's an improvement.

joostlek requested changes Nov 5, 2024
View reviewed changes

joostlek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

There's a merge conflict

home-assistant Bot marked this pull request as draft November 5, 2024 14:42

home-assistant Bot commented Nov 5, 2024

Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

rytilahti marked this pull request as ready for review November 6, 2024 11:23
home-assistant Bot requested a review from joostlek November 6, 2024 11:23
joostlek merged commit c6cb288 into dev Nov 6, 2024
joostlek deleted the tplink/feat/pir_feature branch November 6, 2024 12:40
github-actions Bot locked and limited conversation to collaborators Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

joostlek joostlek approved these changes
bdraco Awaiting requested review from bdraco bdraco is a code owner
+1 more reviewer
CrazyCoder CrazyCoder left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

bdraco

Labels

by-code-owner cla-signed Hacktoberfest has-tests integration: tplink new-feature Quality Scale: platinum small-pr PRs with less than 30 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL