FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add tplink diagnostics by rytilahti · Pull Request #65822 · home-assistant/core · GitHub

  1. home-assistant
  2. core

Repository navigation

Add tplink diagnostics - #65822

Merged
bdraco merged 6 commits into
home-assistant:devfrom
rytilahti:feat/tplink/add_diagnostics
Feb 6, 2022
ConversationCommits (6)ChecksFiles changed
Merged

Add tplink diagnostics#65822
bdraco merged 6 commits into
home-assistant:devfrom
rytilahti:feat/tplink/add_diagnostics

Conversation

rytilahti commented Feb 5, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Proposed change

Add diagnostics to tplink integration, containing the contents of the last device response.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

probot-home-assistant Bot commented Feb 5, 2022

Copy link
Copy Markdown

Hey there @TheGardenMonkey, mind taking a look at this pull request as it has been labeled with an integration (tplink) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

rytilahti commented Feb 5, 2022

Copy link
Copy Markdown
Member Author

@bdraco would you mind testing with the python-kasa's modularize branch to see if the cloud module has some other identifiers besides username that should be redacted?

rytilahti marked this pull request as draft February 5, 2022 18:29
bdraco self-requested a review February 5, 2022 19:09

bdraco commented Feb 6, 2022

Copy link
Copy Markdown
Member

config_entry-tplink-5f1ac3337e1c923eb088c0e55f6a8f5a.json.txt
Seems fine to me

rytilahti force-pushed the feat/tplink/add_diagnostics branch from 80c4f85 to 22550ab Compare February 6, 2022 17:15

rytilahti commented Feb 6, 2022

Copy link
Copy Markdown
Member Author

Great, thanks! I think this is ready to go if that internal access is fine.

rytilahti marked this pull request as ready for review February 6, 2022 17:17

bdraco commented Feb 6, 2022

Copy link
Copy Markdown
Member

We have to add tests for this since its quality scale platinum

rytilahti commented Feb 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

There are now some preliminary tests in place, primarily testing that the redactions are working correctly. The entry is no more in the diagnostics data, and the alias was added to the list of information to redact. consts.py had code that's not used anymore since the python-kasa conversion, so it's also gone.

I'm wondering if the tests should be converted to use hass.config_entries.async_setup instead of async_setup_component across the board, either by extending that newly introduced helper, or by creating a mock that performs the same..

bdraco self-requested a review February 6, 2022 21:22
bdraco reviewed Feb 6, 2022
View reviewed changes
Comment thread tests/components/tplink/test_diagnostics.py Outdated

bdraco commented Feb 6, 2022

Copy link
Copy Markdown
Member

I'm wondering if the tests should be converted to use hass.config_entries.async_setup instead of async_setup_component across the board, either by extending that newly introduced helper, or by creating a mock that performs the same..

I don't think it really matters so much. Ideally we pick one or the other, but both are acceptable.

rytilahti force-pushed the feat/tplink/add_diagnostics branch from 6b436a9 to 987b3b0 Compare February 6, 2022 22:35
bdraco merged commit fd7e2e7 into home-assistant:dev Feb 6, 2022
rytilahti deleted the feat/tplink/add_diagnostics branch February 6, 2022 23:10
github-actions Bot locked and limited conversation to collaborators Feb 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

bdraco bdraco approved these changes

Assignees

No one assigned

Labels

by-code-owner cla-signed integration: tplink new-feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL