Revised Version - #38
Open
MohammedSDev wants to merge 23 commits into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
make send() public.
Copy link
Copy Markdown
|
While I'm not the owner of this repo, I would assume they will want you to get the junit tests working and passing before merging this, as well as adding any new tests for the additional functionality you've provided here. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebSocket connection should be properly closed when it’s in the "closing" state. This is crucial to avoid leaving hanging connections or resources.
It’s a good practice to ensure that if a connection is already in the process of being established (connecting state), no additional attempts should be made. This can prevent race conditions and multiple attempts to open the same connection.
Introducing a custom exception class (WebSocketException) is useful for catching and handling WebSocket-related errors more effectively.
This function checks whether the current WebSocket connection has a subscription. It can be valuable in preventing the same subscription channels from being added twice.
This method might be used to define a threshold for considering connections as stale.
This improves the ability to track the connection state (e.g., connecting, connected, closed), which helps in handling different scenarios like reconnection or error handling.
Introducing a status like IDEAL as an initialization status can help signify that the WebSocket is not yet connected and is ready to initiate the connection, which could be important for managing transitions even before the connection starts.
Automatic ping-pong mechanisms are often used to keep WebSocket connections alive and to detect when a connection is lost.