is(): correct is() for types - #1204
Merged
hsutter merged 14 commits intoAug 10, 2024
Merged
hsutter merged 14 commits into
hsutter merged 14 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
filipsajdak
force-pushed
the
fsajdak-extension-of-is-part2
branch
3 times, most recently
from
0e0b8db to
8ad390a
Compare
August 5, 2024 23:39
hsutter
reviewed
Aug 9, 2024
Comment thread
include/cpp2util.h
Comment thread
include/cpp2util.h
Comment thread
include/cpp2util.h
Comment thread
include/cpp2util.h
Non-polymorphic types cannot be casted with dynamic_cast
std::is_polymorphic_v<X> when X is pointer returns false that means that later std::is_pointer_v<X> will always be false
Support for is<X*>(ptr)
filipsajdak
force-pushed
the
fsajdak-extension-of-is-part2
branch
from
c887d8a to
dbc388d
Compare
August 10, 2024 12:56
Copy link
Copy Markdown
Owner
|
Thanks! I think all our review questions are resolved -- are there any more commits I should wait for before merging, or can I go ahead and merge now? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@hsutter please merge. I will rebase other PRs on top of this PR. thank you! |
Sorry, something went wrong.
Copy link
Copy Markdown
Owner
|
Thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the inspection of variables.