FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update for sanitizing regex results and matcher strings. by MaxSagebaum · Pull Request #1224 · hsutter/cppfront · GitHub

/ cppfront Public

Update for sanitizing regex results and matcher strings. - #1224

Merged
hsutter merged 2 commits into
hsutter:mainfrom
MaxSagebaum:bugfix/regex_result_output
Aug 14, 2024
ConversationCommits (2)ChecksFiles changed
Merged

Update for sanitizing regex results and matcher strings.#1224
hsutter merged 2 commits into
hsutter:mainfrom
MaxSagebaum:bugfix/regex_result_output

Conversation

MaxSagebaum commented Aug 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

The matcher strings and the result output for regular expression are now sanitized. Special characters like newline are replaced with the escaped version.

closes #1223

MaxSagebaum mentioned this pull request Aug 13, 2024
Closed
MaxSagebaum changed the title Update for sanitizing regex results and matcher strings. WIP: Update for sanitizing regex results and matcher strings. Aug 13, 2024

MaxSagebaum commented Aug 13, 2024

Copy link
Copy Markdown
Contributor Author

Letting the test suite run, so that I can update the test results.

filipsajdak mentioned this pull request Aug 13, 2024
Merged
MaxSagebaum force-pushed the bugfix/regex_result_output branch from 7cd2beb to 626ad0a Compare August 14, 2024 06:31

MaxSagebaum commented Aug 14, 2024

Copy link
Copy Markdown
Contributor Author

@hsutter ready to merge

The last regression problem is about a temporary directory. I created a bug report for that #1225.

MaxSagebaum changed the title WIP: Update for sanitizing regex results and matcher strings. Update for sanitizing regex results and matcher strings. Aug 14, 2024
hsutter merged commit 07d641b into hsutter:main Aug 14, 2024

hsutter commented Aug 14, 2024

Copy link
Copy Markdown
Owner

Thanks again for this! 🎉

hsutter commented Aug 18, 2024

Copy link
Copy Markdown
Owner

Hmm, I just noticed that apparently as of this PR we broke a five regression test cases / compiler combinations?

mixed-type-safety-1: on GCC 10, Clang 18

pure2-type-safety-1: on GCC 14, Clang 18

pure2-requires-clauses: on GCC 10

I might be misreading and it might not have been due to this PR, but if I'm reading it correctly these five files disappeared as of this PR?

hsutter commented Aug 18, 2024

Copy link
Copy Markdown
Owner

Ah, I see @filipsajdak has explained the reason in this comment: #1203 (comment)

It seems to be a requires-clause thing, rather than something about this PR. I'll go take a look.

Thanks again for this!

filipsajdak commented Aug 20, 2024

Copy link
Copy Markdown
Contributor

@hsutter here is the solution to above issues: #1250

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] New clone of repo shows modification to pure2-regex_10_escapes.cpp.execution

3 participants

Back | FazBrowse Home | New Git URL