is()/as(): refactor of is() and as() for std::any and std::optional to new design (part 3 of n) - #1251
Merged
hsutter merged 3 commits intoSep 3, 2024
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
filipsajdak
force-pushed
the
fsajdak-extension-of-is-part4
branch
8 times, most recently
from
1e518de to
bcb6706
Compare
August 27, 2024 21:51
filipsajdak
force-pushed
the
fsajdak-extension-of-is-part4
branch
2 times, most recently
from
4960b77 to
4e3a1b5
Compare
August 29, 2024 14:56
filipsajdak
force-pushed
the
fsajdak-extension-of-is-part4
branch
from
4e3a1b5 to
fb5e13b
Compare
August 29, 2024 21:44
Copy link
Copy Markdown
Contributor
Author
|
This PR has an experimental continuation here: #1267 that uses type_safety to handle failures. |
Sorry, something went wrong.
Copy link
Copy Markdown
Owner
|
Thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligning implementation of is() and as() to the rest of the functions.
Keep them as separate functions to make them examples of how to extend is()/as() with custom-made functions.
This PR is based on #1203