FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Updates for missing features in regular expressions. by MaxSagebaum · Pull Request #1337 · hsutter/cppfront · GitHub

Updates for missing features in regular expressions. - #1337

Merged
hsutter merged 16 commits into
hsutter:mainfrom
MaxSagebaum:feature/regex_updates
Jan 31, 2025
Merged

hsutter merged 16 commits into
hsutter:mainfrom
MaxSagebaum:feature/regex_updates

Conversation

Copy link
Copy Markdown
Contributor

Added some of the missing features for regular expression.

  • There is now a find_all method for the regular expressions.
  • Added handling of \G.
  • Added look behind matchers.
  • Added atomic group tokens.

The PR can be squashed into one commit. I left the commits for better review granularity.

Copy link
Copy Markdown
Contributor Author

I am still updating the results.

Copy link
Copy Markdown
Contributor Author

All regex related tests are updated. The remaining failures are from other tests.

hsutter commented Jan 15, 2025

Copy link
Copy Markdown
Owner

Thanks! As described in #1322, I will need a new one-time CLA that will cover all your future contributions. I've emailed you the new CLA, and one it's completed I can look at PRs.

Copy link
Copy Markdown
Contributor Author

I signed the document.

hsutter commented Jan 31, 2025

Copy link
Copy Markdown
Owner

Looks great, thanks Max!

hsutter merged commit ec1f98a into hsutter:main Jan 31, 2025

Copy link
Copy Markdown
Contributor

Hey, sorry to necromance a pull request, but it looks like you only checked in the .cpp of pure2-regex_20_lookbehind and not the .cpp2. Any chance that could get fixed?

Copy link
Copy Markdown
Contributor Author

Thanks for the hint. I added the file and created a pull request.

#1407

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL