Fix HTMLSerializer on Python2 shouldn't assert unicode strings. - #210
Closed
faerloev wants to merge 2 commits into
Closed
Fix HTMLSerializer on Python2 shouldn't assert unicode strings.#210faerloev wants to merge 2 commits into
faerloev wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Fix HTMLSerializer on Py2 shouldn't assert unicode strings.
Copy link
Copy Markdown
Member
|
Why? When does it fail? As far as I'm concerned, those assertions are valid. They should only be called with unicode strings as arguments. Where are they getting called with anything else? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@faerloev do you have any traceback for the assertion failing? |
Sorry, something went wrong.
Copy link
Copy Markdown
|
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the HTMLSerializer fails with an assert on unicode strings.