FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add missing MathML tags for annotations. #183 by fred-wang · Pull Request #331 · html5lib/html5lib-python · GitHub

Add missing MathML tags for annotations. #183 - #331

Open
fred-wang wants to merge 1 commit into
html5lib:masterfrom
fred-wang:mathml-annotations
Open

Add missing MathML tags for annotations. #183#331
fred-wang wants to merge 1 commit into
html5lib:masterfrom
fred-wang:mathml-annotations

Conversation

Copy link
Copy Markdown

willkg added this to the 1.0 milestone Oct 3, 2017

willkg commented Oct 31, 2017

Copy link
Copy Markdown
Contributor

The sanitizer is built to make sure the output is safe regardless of what the input was. So in order to approve adding these, I need to feel confident that these are safe to add.

There's this comment which you wrote that talks about the safety of adding these bits:

#181 (comment)

However, I don't know anything about MathML and can't evaluate that, so I can't approve this. We'll need someone who understands this to yay/nay it preferably with some proof. I'll hunt around and see if I can find someone I know.

willkg commented Nov 6, 2017

Copy link
Copy Markdown
Contributor

I can't find anyone. I'm going to nix this from the 1.0 milestone.

willkg removed this from the 1.0 milestone Nov 6, 2017

Copy link
Copy Markdown
Author

@willkg What's the plan on this? Did you ask @jruderman ?

willkg commented Jun 5, 2018

Copy link
Copy Markdown
Contributor

@fred-wang I didn't find anyone, so I nixed it from the 1.0 milestone. After I got 1.0 out, I stepped off of this project.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL