FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Remove last note about nose by willkg · Pull Request #366 · html5lib/html5lib-python · GitHub

/ html5lib-python Public

Remove last note about nose - #366

Merged
gsnedders merged 2 commits into
html5lib:masterfrom
willkg:182-nix-nose
Nov 29, 2017
ConversationCommits (2)ChecksFiles changed
Merged

Remove last note about nose#366
gsnedders merged 2 commits into
html5lib:masterfrom
willkg:182-nix-nose

Conversation

willkg commented Nov 27, 2017

Copy link
Copy Markdown
Contributor

This nixes the last bit about nose re: issue #182.

willkg added this to the 1.0 milestone Nov 27, 2017

willkg commented Nov 27, 2017

Copy link
Copy Markdown
Contributor Author

This is very cosmetic. Given the content and location of the file, part of me thinks we should remove it altogether.

@gsnedders @jgraham Can one of you review this, please?

gsnedders previously approved these changes Nov 28, 2017
View reviewed changes

gsnedders commented Nov 28, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

I'd also be totally happy with removing it, honestly. Merge this if you want, or just delete it.

willkg commented Nov 28, 2017

Copy link
Copy Markdown
Contributor Author

I'll change this PR to remove that file. Thank you!

gsnedders previously approved these changes Nov 28, 2017
View reviewed changes
Remove last note about nose
e9b3a29
Remove html5lib/tests/README file
b075384 
This file wasn't informative enough beyond existing documentation. Best
to remove it.

willkg commented Nov 29, 2017

Copy link
Copy Markdown
Contributor Author

@gsnedders I rebased on master tip to pick up the pytest fixes so that CI would pass. That caused the previous reviews to become stale, so this needs another review. Sorry about that!

codecov-io commented Nov 29, 2017 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #366 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #366   +/-   ##
=======================================
  Coverage   90.78%   90.78%           
=======================================
  Files          50       50           
  Lines        6927     6927           
  Branches     1322     1322           
=======================================
  Hits         6289     6289           
  Misses        482      482           
  Partials      156      156

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b515f5...b075384. Read the comment docs.

gsnedders merged commit b105f6e into html5lib:master Nov 29, 2017

willkg commented Nov 29, 2017

Copy link
Copy Markdown
Contributor Author

Thank you!

willkg deleted the 182-nix-nose branch November 29, 2017 14:20
willkg mentioned this pull request Nov 29, 2017
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gsnedders gsnedders approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL