Remove unnecessary compatibility shim for BytesIO - #401
Merged
gsnedders merged 1 commit intoOct 1, 2018
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
io.BytesIO is available on all supported Pythons. Can simplify by assuming the import will succeed.
Copy link
Copy Markdown
Contributor
Author
|
The AppVeyor failures are unrelated to this changed and are fixed in #397. |
Sorry, something went wrong.
gsnedders
approved these changes
Oct 1, 2018
gsnedders
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Is this not supported from 2.6? I'm not sure we've ever supported < 2.6 and 3, so I dunno why that's even there. Oh well! Thanks for catching this.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
io.BytesIO is available on all supported Pythons. Can simplify by assuming the import will succeed.