Allow data: to not be part of sanitizer’s allowed protocols - #412
Open
charmander wants to merge 1 commit into
Open
Allow data: to not be part of sanitizer’s allowed protocols#412charmander wants to merge 1 commit into
charmander wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
When `data:` wasn’t permitted, it could attempt to `del attrs[attr]` twice.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
=======================================
Coverage 90.79% 90.79%
=======================================
Files 50 50
Lines 6952 6952
Branches 1328 1328
=======================================
Hits 6312 6312
Misses 481 481
Partials 159 159
Continue to review full report at Codecov.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
The change looks valid, but shouldn't there be a test case for this? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When data: wasn’t permitted, it could attempt to del attrs[attr] twice.