Bump Flake8 to fix CI for Python 3.7 - #554
Merged
ambv merged 2 commits intoMar 1, 2023
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ute 'get' on Python 3.7
jgraham
approved these changes
Oct 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python 3.7 CI job has started failing:
self._load_entrypoint_plugins() File "/home/runner/work/html5lib-python/html5lib-python/.tox/py/lib/python3.7/site-packages/flake8/plugins/manager.py", line 254, in _load_entrypoint_plugins eps = importlib_metadata.entry_points().get(self.namespace, ()) AttributeError: 'EntryPoints' object has no attribute 'get' ERROR: InvocationError for command /home/runner/work/html5lib-python/html5lib-python/.tox/py/bin/flake8 . (exited with code 1)This is because importlib_metadata 5.0 removes some deprecations, and it's a dependency of Flake8. But new Flake8 works, so let's update:
Also fix the new Flake8 findings: