FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Use `swift_versions` DSL instead of `.swift-version` file. by dnkoutso · Pull Request #425 · httpswift/swifter · GitHub

Use swift_versions DSL instead of .swift-version file. - #425

Merged
Vkt0r merged 1 commit into
httpswift:stablefrom
dnkoutso:swift_version_podspec
Jul 21, 2019
Merged

Use swift_versions DSL instead of .swift-version file.#425
Vkt0r merged 1 commit into
httpswift:stablefrom
dnkoutso:swift_version_podspec

Conversation

Copy link
Copy Markdown
Contributor

The .swift-version file has been deprecated and by specifying that in the podspec it means that consumers of Swifter will always get the correct version of Swift when compiling Swifter.

dnkoutso force-pushed the swift_version_podspec branch from 50b2223 to 6487429 Compare July 20, 2019 21:54

swifter-bot commented Jul 20, 2019
edited
Loading

Copy link
Copy Markdown
2 Warnings
⚠️ It seems like you’ve added new tests to the library. If that’s the case, please update the XCTestManifests.swift file running in your terminal the command swift test --generate-linuxmain.
⚠️ If you ran the command swift test --generate-linuxmain in your terminal, please remove the line testCase(IOSafetyTests.__allTests__IOSafetyTests), from public func __allTests() -> [XCTestCaseEntry] in the bottom of the file. For more reference see #366.
1 Message
📖 Hey, @dnkoutso 👋.

Generated by 🚫 Danger

Copy link
Copy Markdown
Contributor Author

let me know if you do not want to point to stable branch.

dnkoutso force-pushed the swift_version_podspec branch from 6487429 to 8eea555 Compare July 20, 2019 21:57

Vkt0r left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@dnkoutso Thanks for taking the time to create this PR! Looks good 👍.

Vkt0r merged commit 70355c4 into httpswift:stable Jul 21, 2019

Copy link
Copy Markdown
Contributor Author

thank you!

tomieq pushed a commit to tomieq/swifterfork that referenced this pull request Apr 1, 2021
Use `swift_versions` DSL instead of `.swift-version` file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL