FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[tests] Changes to the `torch.compile()` CI and tests by sayakpaul · Pull Request #11508 · huggingface/diffusers · GitHub

/ diffusers Public

[tests] Changes to the torch.compile() CI and tests - #11508

Merged
sayakpaul merged 13 commits into
mainfrom
compile-ci
May 26, 2025
ConversationCommits (13)ChecksFiles changed
Merged

[tests] Changes to the torch.compile() CI and tests#11508
sayakpaul merged 13 commits into
mainfrom
compile-ci

Conversation

sayakpaul commented May 6, 2025

Copy link
Copy Markdown
Member

What does this PR do?

  • Removes the CUDA compile docker container
  • Consistency in how compilation cache is cleared and ensuring we start a compilation run with fresh cache
  • Removes unnecessary compilation tests from pipelines

Regarding the final point, I think we already test torch.compile() support for popular models and doing it at the pipeline-level makes little sense to me. But no strong opinions.

sayakpaul requested a review from DN6 May 6, 2025 10:06

sayakpaul commented May 22, 2025

Copy link
Copy Markdown
Member Author

@DN6 a gentle ping.

DN6 approved these changes May 26, 2025
View reviewed changes

DN6 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good 👍🏽 Thanks. Minor comments.

Comment thread tests/models/transformers/test_models_transformer_hunyuan_video.py
expected_set = {"HunyuanVideoTransformer3DModel"}
super().test_gradient_checkpointing_is_applied(expected_set=expected_set)

@require_torch_gpu

DN6 May 26, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Would make sense to add these decorators to the top of the Mixin no?

sayakpaul May 26, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

These decorators are present in the mixin:

diffusers/tests/models/test_modeling_common.py

Lines 1762 to 1765 in b5c2050

@require_torch_gpu
@require_torch_2
@is_torch_compile
@slow

Comment thread .github/workflows/nightly_tests.yml

container:
image: diffusers/diffusers-pytorch-compile-cuda
image: diffusers/diffusers-pytorch-cuda

DN6 May 26, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Small nit. We can remove the -k "compile" in the test runner step.

sayakpaul merged commit 4af76d0 into main May 26, 2025
sayakpaul deleted the compile-ci branch May 26, 2025 15:31

sayakpaul commented May 26, 2025

Copy link
Copy Markdown
Member Author

Thanks for the reviews, @DN6! Hope to make our compile CI better and better.

DN6 added a commit that referenced this pull request May 26, 2025
Revert "[tests] Changes to the torch.compile() CI and tests (#11508)"
2a7bb53 
This reverts commit 4af76d0.
DN6 mentioned this pull request May 26, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DN6 DN6 approved these changes

Assignees

No one assigned

Labels

torch.compile

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL