fix: 修复使用Nacos GRPC客户端做服务注册发现且没使用配置中心时，仍然发送配置监听请求的问题 - #7708
Open
MorriosL wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@limingxinleo 辛苦大佬帮看看这个，年前还会不会再发个版本？ |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@limingxinleo 辛苦大佬看看这个PR，业务里有确实有只用到服务治理，没用到配置中心的需求 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@huangdijia 辛苦帮忙review下，业务上确实需要使用nacos的grpc做服务治理 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
运行环境：hyperf/hyperf:8.3-alpine-v3.20-swoole-v5.1
Hyperf版本：3.1
复现场景：有使用基于nacos的服务注册发现，但未使用配置中心。按默认配置下启动服务10秒后会出现以下报错
[ERROR] Hyperf\Http2Client\Exception\TimeoutException: Recv timeout. in /data/project/vendor/hyperf/http2-client/src/Client.php:114
Stack trace:
#0 /data/project/vendor/hyperf/http2-client/src/Client.php(133): Hyperf\Http2Client\Client->recv()
#1 /data/project/vendor/hyperf/nacos/src/GrpcClient.php(110): Hyperf\Http2Client\Client->request()
#2 /data/project/vendor/hyperf/nacos/src/GrpcClient.php(158): Hyperf\Nacos\GrpcClient->request()
#3 /data/project/vendor/hyperf/nacos/src/GrpcClient.php(233): Hyperf\Nacos\GrpcClient->listen()
#4 /data/project/vendor/hyperf/coroutine/src/Coroutine.php(80): Hyperf\Nacos\GrpcClient->Hyperf\Nacos{closure}()
#5 [internal function]: Hyperf\Coroutine\Coroutine::Hyperf\Coroutine{closure}()
#6 {main}
[WARNING] Hyperf\Http2Client\Exception\TimeoutException: Recv timeout. in /data/project/vendor/hyperf/http2-client/src/Client.php:114
Stack trace:
#0 /data/project/vendor/hyperf/http2-client/src/Client.php(133): Hyperf\Http2Client\Client->recv()
#1 /data/project/vendor/hyperf/nacos/src/GrpcClient.php(110): Hyperf\Http2Client\Client->request()
#2 /data/project/vendor/hyperf/nacos/src/GrpcClient.php(194): Hyperf\Nacos\GrpcClient->request()
#3 /data/project/vendor/hyperf/coroutine/src/Coroutine.php(80): Hyperf\Nacos\GrpcClient->Hyperf\Nacos{closure}()
#4 [internal function]: Hyperf\Coroutine\Coroutine::Hyperf\Coroutine{closure}()
#5 {main}
原因：vendor/hyperf/nacos/src/GrpcClient.php的listen方法中，即使没使用配置中心，也会无差别的发送空的配置监听请求