Expose build-root-directory in gradle action - #60
Open
samarth-gupta-traceable wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
samarth-gupta-traceable
requested review from
JBAhire,
aaron-steinfeld,
kotharironak and
ravisingal
as code owners
October 7, 2024 04:43
Comment thread
gradle/action.yml
| steps: | ||
| - uses: gradle/gradle-build-action@v2 | ||
| with: | ||
| build-root-directory: ${{ inputs.build-root-directory }} |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Can we take this opportunity to switch to v3 of the generic action? It looks like gradle switched to a model where you set up gradle rather than call their action directly, but this one delegates to it so should be fine. We still want the common action anyway to pass build args
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
At least 1 approving review is required to merge this pull request.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Expose build-root-directory in gradle action