FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add abstract client tests by shashank11p · Pull Request #246 · hypertrace/javaagent · GitHub

/ javaagent Public

Add abstract client tests - #246

Merged
pavolloffay merged 7 commits into
mainfrom
ENG-7540/abstractHttpClientTest
Feb 3, 2021
ConversationCommits (7)ChecksFiles changed
Merged

Add abstract client tests#246
pavolloffay merged 7 commits into
mainfrom
ENG-7540/abstractHttpClientTest

Conversation

shashank11p commented Jan 29, 2021 •
edited by pavolloffay
Loading

Copy link
Copy Markdown
Contributor

Updates #98

pavolloffay reviewed Feb 1, 2021
View reviewed changes

pavolloffay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good progress 👍

Comment thread testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
Comment thread testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
Comment thread testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
Comment thread testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java
Comment thread testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
Comment thread testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
Comment thread testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
pavolloffay reviewed Feb 2, 2021
View reviewed changes
Comment thread ...rumentation/hypertrace/apachehttpasyncclient/ApacheAsyncClientInstrumentationModuleTest.java Outdated
Comment thread ...rumentation/hypertrace/apachehttpasyncclient/ApacheAsyncClientInstrumentationModuleTest.java Outdated
Comment thread ...rumentation/hypertrace/apachehttpasyncclient/ApacheAsyncClientInstrumentationModuleTest.java Outdated
Comment thread testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
Comment thread testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java
Comment thread testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
Comment thread testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
Comment thread testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
Comment thread testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
Comment thread testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
pavolloffay changed the title Adding AbstractHttpClientTest class for Http client tests Add abstract client tests Feb 2, 2021
shashank11p marked this pull request as ready for review February 2, 2021 12:39
pavolloffay reviewed Feb 2, 2021
View reviewed changes
Comment thread ...nt/instrumentation/hypertrace/apachehttpclient/v4_0/ApacheHttpClientInstrumentationTest.java Outdated
Comment thread testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java
Comment thread testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
Comment thread testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
Comment thread testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java
Comment thread testing-common/src/main/java/org/hypertrace/agent/testing/AbstractHttpClientTest.java Outdated
pavolloffay merged commit 8275b70 into main Feb 3, 2021
pavolloffay deleted the ENG-7540/abstractHttpClientTest branch February 3, 2021 09:14
shashank11p added a commit to shashank11p/javaagent that referenced this pull request Feb 3, 2021
Merge pull request #2 from hypertrace/main
9aa407a 
Add abstract client tests (hypertrace#246)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pavolloffay pavolloffay approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL