✨ Expose reporting config to consumers of javaagent-core so that Filter implementation authors can access them - #327
Merged
ryandens merged 7 commits intoJun 28, 2021
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@pavolloffay I know you have lots of context and perspective on this (re: #322 ) let me know if you have any concerns/feedback! |
Sorry, something went wrong.
ryandens
marked this pull request as ready for review
June 28, 2021 21:28
davexroth
approved these changes
Jun 28, 2021
Copy link
Copy Markdown
Member
|
Yeah this PR should not be needed as the https://github.com/hypertrace/javaagent/blob/main/otel-extensions/src/main/java/org/hypertrace/agent/otel/extensions/config/HypertraceConfig.java is available when the filter is created. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow the HypertraceConfig APIs around reporting and OPA configuration to be exposed to clients following a similar pattern as done with the InstrumentationConfig. PR #322 moved the config implementation out of the javaagent-core package, but some implementations of the Hypertrace Filter API need to access config properties that are not accessible via the InstrumentationConfig object. As this is a public API, I wanted to make it well known that the ReportingConfig.Opa object isn't going to live forever in this repo, as we'd like to eventually remove configuraton options that are intended for use by Traceable to not be included in the Hypertrace repo.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.
N/A