For some reason, actions that use the pull_request_target attribute causes the deefault checkout destination of the checkout action to be whatever is currently the head of origin/main. This can allow build/test errors from PRs make it into the main branch before failing (but not allowing them to be released). An example PR is #337. Note, the GHA all passed on commit e9d665c. However, note the checkout action step for that PR here. It checks out the commit from what was currently the head of origin/main (ref 4a920915c55e3d0e86806482bec736554315100b) and caused the PR to pass all builds, only to have the main build fail once the PR was merged. This resulted in us needing to quickly patch in PR #338.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Any dependent changes have been merged and published in downstream modules
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For some reason, actions that use the pull_request_target attribute causes the deefault checkout destination of the checkout action to be whatever is currently the head of origin/main. This can allow build/test errors from PRs make it into the main branch before failing (but not allowing them to be released). An example PR is #337. Note, the GHA all passed on commit e9d665c. However, note the checkout action step for that PR here. It checks out the commit from what was currently the head of origin/main (ref 4a920915c55e3d0e86806482bec736554315100b) and caused the PR to pass all builds, only to have the main build fail once the PR was merged. This resulted in us needing to quickly patch in PR #338.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.