🚧 upgrade otel 1.6 - #347
Merged
ryandens merged 12 commits intoJan 11, 2022
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ryandens
force-pushed
the
upgrade-otel-1-6
branch
from
ce49872 to
9e5f15e
Compare
September 3, 2021 14:03
ryandens
force-pushed
the
upgrade-otel-1-6
branch
from
fdf2df1 to
b53d9a8
Compare
October 8, 2021 14:14
ryandens
force-pushed
the
upgrade-otel-1-6
branch
2 times, most recently
from
f78b6e7 to
b516820
Compare
January 10, 2022 21:39
ryandens
force-pushed
the
upgrade-otel-1-6
branch
from
56585f4 to
a100ee7
Compare
January 11, 2022 01:24
ryandens
commented
Jan 11, 2022
Comment thread
...try/javaagent/instrumentation/hypertrace/netty/v4_1/NettyChannelPipelineInstrumentation.java
| HttpClientTracingHandler.class.getName(), | ||
| io.opentelemetry.javaagent.instrumentation.netty.v4_1.client | ||
| .HttpClientRequestTracingHandler.class | ||
| io.opentelemetry.javaagent.instrumentation.netty.v4_1.client.HttpClientTracingHandler |
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
this was really hard to catch - this was basically always a copy-paste error but before now it didn't cause any trouble. On Spring webflux the HttpClientRequestTracingHandler has not been added at this point, but we should always have been adding this after the HttpClientTracingHandler anyways
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
It caused the test to hang and would result in really odd hard to debug bahvior.
Sorry, something went wrong.
ryandens
marked this pull request as ready for review
January 11, 2022 02:17
shashank11p
approved these changes
Jan 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates to OTEL 1.6
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.