Prevent iNav widget from silently disappearing when getVersion() startup check fails - #215
Open
suchitmehrotra wants to merge 1 commit into
Open
suchitmehrotra wants to merge 1 commit into
suchitmehrotra wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
…y deregister the widget
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On EdgeTX 2.12.3 (RadioMaster TX16S), main.lua's top-level code calls
string.sub(r, -4) on getVersion()'s result with no nil-guard. EdgeTX's
widget loader drops any widget whose script errors before returning its
definition table — silently, with no error shown — so a failure here
makes the widget vanish from the list entirely instead of failing
visibly.
This wraps that startup block (and the existing create() logic) in
pcall, so the widget always registers, and any real failure shows as
readable on-screen text instead of nothing at all.
Tested on real TX16S / EdgeTX 2.12.3 hardware.
Diagnosed and drafted with help from an AI assistant (Claude); confirmed
against actual firmware behavior on real hardware.
Related to #209.