| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Thanks @neutrinoceros . However, I must say I don't know how to test this... and I'm not keen on merging this straight away onto master. |
Sorry, something went wrong.
|
I should be able to build docs locally with both files and send you the artifacts if you'd like. |
Sorry, something went wrong.
|
So actually it's pretty simple: requirements_direct_pinned.txt is the only alternative that works at the moment. I'll replace requirements.txt with it. |
Sorry, something went wrong.
|
I you'd like, I could add a CI job that mimicks what RTD does, so you don't have to rely on local/manual testing everytime something is upgraded. I think it's also possible to configure RTD to build on pull requests (without publishing the result, of course), but that's out of my hands. |
Sorry, something went wrong.
|
I think that we definitely need a CI job to check the doc. I can have a go at this (or possibly @lih ). Let me know if you start something. |
Sorry, something went wrong.
|
I don't think I will have time to work on it before next year (🥁), but I can certainly pick it up then if needed. |
Sorry, something went wrong.
|
rebasing after #305 was just merged |
Sorry, something went wrong.
|
Instead of having a CI to check that the documentation builds, followed by RTD building it on their side, you could use a CI that builds the documentation and then pushes the HTML pages to GitHub Pages (if the build succeeds). Here is a GitHub Action that I wrote for another project. Feel free to use it if you find it helpful. |
Sorry, something went wrong.
|
Thanks @smaret . For the moment nobody has time to migrate the documentation to Github Pages, so we will keep this as is. |
Sorry, something went wrong.
|
I'm planning to rework this with a pylock.toml file instead of requirements.txt, in the spirit of #395 if it is accepted. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This is a first step towards #191 (missing the automated updates for now, see below)
Notes:
I would recommend using the later (if it works), but the former is probably closer to what has been running on RTD as of late so it can serve as a fallback if the most up-to-date set doesn't fly.
I'm also keeping auto-updates via dependabot for a follow up PR because I want to first know which version of compiled requirements should be kept. This might be a little tricky to test: as far as I'm aware, RTD only runs once a patch is merged (is this right ?).
Also, I'm assuming RTD runs on commits made to master, not develop, so maybe I should target master with this PR ?