| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Note that currently two pull requests exist to amend this PR:
|
Sorry, something went wrong.
@florisvdh Just a suggestion: to be sure it is not forgotten, I added a 'requested changes' review. ;-) |
Sorry, something went wrong.
Add Zenodo vignette from checklist package
delete old version of inboveg tutorial
|
All issue and feedback resolved, thanks for the input! A huge thanks to @LienReyserhove 👏👏👏 for hunting down all the vignettes, translating these into tutorials, and weathering the feedback and format changes. 😄 @LienReyserhove I have also updated the spreadsheet to reflect the current state. |
Sorry, something went wrong.
Sorry, something went wrong.
There was a problem hiding this comment.
For now I'll remove the request changes, as this is done. If needed, I can do a more thorough review tomorrow.
Sorry, something went wrong.
…rials into vignettes-as-tutorials
There was a problem hiding this comment.
Nice work @LienReyserhove and @peterdesmet, thanks 🎉. Just a few things left as far as I could tell!
Sorry, something went wrong.
|
@ElsLommelen no need for a thorough review (we all had a check already, especially @florisvdh), but your approval is needed before this PR can be merged. 😄 |
Sorry, something went wrong.
There was a problem hiding this comment.
Sorry, I didn't know that I had to approve to remove this 'request changes'. Here you are! (I trust @florisvdh did it thoroughly, no time to do it myself today.)
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Description
This PR contains the vignettes as tutorials, as described in #262
All vignettes can be found in the tutorials/content/tutorials folder.
One tutorial equals one vignette. The name of the file follows the convention vignette + package_name+ vignette_name.
The structure of the index.md uses the following structure:
@florisvdh @peterdesmet @ThierryO the revision is all yours
Task list
Previewing the pull request
Thanks to GitHub Actions, an artifact (=zip file) of the rendered website is automatically created for each pull request.