| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
(The commit message says "wip", but no more progress is required: this is ready for review and merge. Thank you in advance!) |
Sorry, something went wrong.
There was a problem hiding this comment.
Hello Falk, the .qmd and the index.md file now contain different code for the wrap_difference() function. I believe the index.md file is correct (%% extent). Should the two not be the same? Is the space you imagine for this wrapping something like the game of snake?
Sorry, something went wrong.
Indeed. Thank you for checking @bserrien , and sorry that I missed that!
Which of the two formulas is correct depends on the usage of extent on the rest of the code (and whether extend is defined as half or full wrapping period). Here, spatial positions can be positive and negative, and thus the full period (analogous: "diameter") is twice the extent, and we shift by 1* extent ("radius"). Just to make sure, I have tried rendering both versions again. ((Y - X + (extent/2)) %% (extent)) - (extent/2) produces the following wraps: Conclusion that the formula in .qmd was correct, it must be: ((Y - X + (extent)) %% (2*extent)) - (extent))
Nice analogy; and maybe the availability of old nokia phones in my teens has lead to a subconscious "snake" image. But that was not my first thought. |
Sorry, something went wrong.
There was a problem hiding this comment.
Hi Falk, thanks for correcting me on the modulo. I will now approve the revision.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This PR corrects minor errors in the tutorial on spatial analysis / variograms.
This has very minor implications for the actual (randomly generated) data.
Therefore, I suggest to not re-calculate and re-commit the figure binaries.
(Instead, I have simply corrected the respective code lines.)