FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add support for parameter binding to built queries by eranl · Pull Request #1010 · influxdata/influxdb-java · GitHub

/ influxdb-java Public

Add support for parameter binding to built queries - #1010

Merged
majst01 merged 3 commits into
influxdata:masterfrom
eranl:built-query-parameters
Mar 25, 2025
ConversationCommits (3)ChecksFiles changed
Merged

Add support for parameter binding to built queries#1010
majst01 merged 3 commits into
influxdata:masterfrom
eranl:built-query-parameters

Conversation

eranl commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

Pulled up bound parameter support from BoundParameterQuery to Query, so that they can be used with built queries, and added support for that.

Also:

  • Decoupled requiresPost from parameters, as they are unrelated
  • Made InfluxDBService more consistent, by making all query methods use GET, and all postQuery methods use POST

Fixes #1009.

Pulled up bound parameter support from BoundParameterQuery to Query, …
a07348c 
…so that they can be used with built queries, and added support for that.

Decoupled requiresPost from parameters, as they are unrelated.
Made InfluxDBService more consistent, by making all query methods use GET, and all postQuery methods use POST.

eranl commented Mar 14, 2025

Copy link
Copy Markdown
Contributor Author

@majst01, are these failures real? I can't figure out what they mean.

majst01 commented Mar 16, 2025

Copy link
Copy Markdown
Collaborator

There has been no CI build for a long time, so i dont know

eranl commented Mar 16, 2025

Copy link
Copy Markdown
Contributor Author

Ok, figured it out - I introduced an overloading bug while reworking InfluxDBService. Fixed.

majst01 commented Mar 17, 2025

Copy link
Copy Markdown
Collaborator

Nice, can you add the relevant changes to the documentation ?

Update doc
412b6ec 
Improve test

eranl commented Mar 17, 2025

Copy link
Copy Markdown
Contributor Author

can you add the relevant changes to the documentation ?

Done. Also, improved the test a bit.

majst01 commented Mar 18, 2025

Copy link
Copy Markdown
Collaborator

I tend to merge this PR as the very last one before archiving this repo, WDYT ?

eranl commented Mar 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

From my perspective, there's still no viable alternative to InfluxQL v1 (Flux is effectively deprecated, and OSS v3 is in beta), so this library is very much in prime time. Am I missing something?

majst01 merged commit 99fcacc into influxdata:master Mar 25, 2025

majst01 commented Mar 25, 2025

Copy link
Copy Markdown
Collaborator

I reached out the influxdata guys to tag a release

eranl deleted the built-query-parameters branch March 25, 2025 12:37

eranl commented Mar 25, 2025

Copy link
Copy Markdown
Contributor Author

Thanks.

If you're still interested in transferring this repo, let me know.

majst01 commented Mar 28, 2025

Copy link
Copy Markdown
Collaborator

Thanks.

If you're still interested in transferring this repo, let me know.

I asked influxdata to add you as a co-maintainer.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

majst01 majst01 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for parameter binding to built queries

2 participants

Back | FazBrowse Home | New Git URL