FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Default column name to pojo field name, and add `allFields` mode to `Measurement` annotation by eranl · Pull Request #972 · influxdata/influxdb-java · GitHub

/ influxdb-java Public

Default column name to pojo field name, and add allFields mode to Measurement annotation - #972

Merged
majst01 merged 3 commits into
influxdata:masterfrom
eranl:allFields
Dec 2, 2023
ConversationCommits (3)ChecksFiles changed
Merged

Default column name to pojo field name, and add allFields mode to Measurement annotation#972
majst01 merged 3 commits into
influxdata:masterfrom
eranl:allFields

Conversation

eranl commented Dec 2, 2023

Copy link
Copy Markdown
Contributor

if @Column is used without a name, the annotated field's name is used as the column name.

In addition, when a pojo is annotated with @Measurement(name = "...", allFields = true), then all its fields are loaded or saved.
Finally, an @Exclude annotation can be used for opting a field out in this mode.

Fixes #971.

codecov-commenter commented Dec 2, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d3a7bbc) 61.22% compared to head (32d31ac) 61.28%.

❗ Current head 32d31ac differs from pull request most recent head aeaba32. Consider uploading reports for the commit aeaba32 to get more accurate results

Files Patch % Lines
src/main/java/org/influxdb/dto/Point.java 81.81% 0 Missing and 2 partials ⚠️
...n/java/org/influxdb/impl/InfluxDBResultMapper.java 88.88% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #972      +/-   ##
============================================
+ Coverage     61.22%   61.28%   +0.06%     
- Complexity      443      450       +7     
============================================
  Files            70       70              
  Lines          2579     2591      +12     
  Branches        271      277       +6     
============================================
+ Hits           1579     1588       +9     
  Misses          932      932              
- Partials         68       71       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

majst01 commented Dec 2, 2023

Copy link
Copy Markdown
Collaborator

Nice PR, thanks for you contribution, can you please also add a bit of documentation of you new features, best place would be here.

If this is done, i am happy to merge

eranl commented Dec 2, 2023

Copy link
Copy Markdown
Contributor Author

can you please also add a bit of documentation of you new features, best place would be here.

Updated. Please review.

majst01 merged commit ba9bfeb into influxdata:master Dec 2, 2023
eranl deleted the allFields branch December 2, 2023 17:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

majst01 majst01 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Default column name to pojo field name, and add allFields mode to Measurement annotation

3 participants

Back | FazBrowse Home | New Git URL