FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[pull] main from danny-avila:main by pull[bot] · Pull Request #198 · innFactory/agents · GitHub

[pull] main from danny-avila:main - #198

Merged
pull[bot] merged 5 commits into
innFactory:mainfrom
danny-avila:main
Aug 27, 2026
Merged

[pull] main from danny-avila:main#198
pull[bot] merged 5 commits into
innFactory:mainfrom
danny-avila:main

Conversation

pull Bot commented Aug 27, 2026
edited
Loading

Copy link
Copy Markdown

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

danny-avila and others added 5 commits August 27, 2026 07:12
…ank (#475)

* fix: read Keenable page text from snippet, not description

Keenable sends both fields on every result: snippet carries the page text and
description is the page's meta description, which is empty for most pages. The
mapping used `result.description ?? result.snippet`, and since ?? only falls
through null and undefined, the empty description won every time and organic
sources came back with a title, a link and no text.

Reads snippet first now, with description as the fallback. The page text is
whole-page rather than excerpt-sized, so it is whitespace-collapsed and capped
at 500 chars to keep it comparable to the other providers here and out of the
reranker's and the LLM output budget's way.

The existing test passed because its fixture had a populated description and no
snippet, a shape the API never returns; it now uses the real one.

* fix: pick the snippet on emptiness, not nullishness

The new toSnippet still chained with ??, so a result carrying `snippet: ''`
alongside a populated description kept the empty string: the same failure the
commit set out to fix, only with the two fields swapped.

Both fields are now defaulted to '' and the pick is an explicit emptiness
check, which also clears the strict-boolean-expressions warning a || chain
raises here. Covered by a test that fails on the ?? version.

* chore: restore package-lock.json to the base version

The lockfile was rewritten by a local npm install on macOS, which dropped the
`libc` selector from 16 optional native binding entries. On a Linux `npm ci`
that makes both the glibc and musl variants eligible whenever cpu and os
match, so the wrong binding can be installed. The fix in this PR is
source-only, so the lockfile is back to what the base has.

---------

Co-authored-by: Ilya Bogin <ilya.bogin@keenable.ai>
pull Bot locked and limited conversation to collaborators Aug 27, 2026
pull Bot added the ⤵️ pull label Aug 27, 2026
pull Bot merged commit af6930f into innFactory:main Aug 27, 2026
1 check passed
pull Bot deployed to publish August 27, 2026 16:44 Active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL