JCL-402: Refactor HTTP exception constructors - #1161
Closed
NSeydoux wants to merge 14 commits into
Closed
NSeydoux wants to merge 14 commits into
NSeydoux wants to merge 14 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Initial ClientHttpException class Create HTTP status enum Add some tests Add javadoc Refactor HttpStatus Add specialized builder to ProblemDetails Add missing header Make problem details parsing more resilient Add tests for problem details parsing The tests are in the solid-client module, because it will need the additional json service anyways in the test dependencies for testing the rest of this feature, and putting these tests in the api module creates a circular dependency. License header
This was referenced Apr 14, 2024
NSeydoux
marked this pull request as ready for review
April 14, 2024 22:07
langsamu
reviewed
Apr 15, 2024
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Would it not make more sense to move all the relevant fields and properties to the ClientHttpException?
It seems to belong there rather on this specialization.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Actually these changes make this PR small enough that it can be bundled together with #1160
Sorry, something went wrong.
the JSON was invalid, causing the intended code path not to be used.
NSeydoux
force-pushed
the
JCL-402/problem-details-exceptions
branch
from
608e632 to
92358fa
Compare
April 16, 2024 07:51
The exception are now built taking a ProblemDetails in. Use HttpStatus from API module as reference
NSeydoux
force-pushed
the
JCL-402/problem-details-exceptions
branch
from
92358fa to
c41758e
Compare
April 16, 2024 08:08
Copy link
Copy Markdown
Contributor
Author
|
I applied the changes here to #1160 |
Sorry, something went wrong.
NSeydoux
force-pushed
the
JCL-460/problem-details-class-http-status
branch
from
8b193a9 to
71d6302
Compare
April 16, 2024 20:47
Copy link
Copy Markdown
Contributor
Author
|
This is no longer required based on the refactoring of #1160 . |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTTP exception are now built taking a ProblemDetails in.