Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
|
SonarQube Quality Gate
|
Sorry, something went wrong.
acoburn
enabled auto-merge (squash)
July 11, 2024 17:14
edwardsph
approved these changes
Jul 11, 2024
edwardsph
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At present, the AccessGrantClient processes Access Credentials with either the shorter localname (e.g. SolidAccessGrant, SolidAccessRequest, SolidAccessDenial) or the fully qualified name (e.g. http://www.w3.org/ns/solid/vc#SolidAccessGrant). There are cases where a qualified name, such as vc:AccessGrantDenial, will be returned from an Access Grant server, and these should be supported as well.
Resolves #1407
Specifically, this adds support for qualified type names with the vc: prefix across the various Access Grant types. In addition, the testing has been expanded to include better coverage of SolidAccessDenial types.