JCL-328: Deprecate UmaSession - #411
Merged
acoburn merged 2 commits intoApr 11, 2023
Merged
acoburn merged 2 commits into
acoburn merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
timea-solid
temporarily deployed
to
ESS PodSpaces
April 11, 2023 07:28 — with 
GitHub Actions
Inactive
timea-solid
temporarily deployed
to
ESS PodSpaces
April 11, 2023 07:28 — with
GitHub Actions
Inactive
timea-solid
approved these changes
Apr 11, 2023
timea-solid
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Very good find! I like it a lot that we keep the code clean and efficient.
Sorry, something went wrong.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the UmaAuthenticationProvider is used extensively, the UmaSession is not really used at all.
Initially, the thought was that the UmaSession object would be used to wrap other session objects to make them usable in the context of UMA, but that's not how these APIs evolved. Now, the UmaSession is entirely superfluous.