JCL-337: Serialize expiration date as an ISO 8601 string - #437
Merged
timea-solid merged 3 commits intoMay 8, 2023
Merged
timea-solid merged 3 commits into
timea-solid merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
acoburn
force-pushed
the
JCL-337-access-grant-issue-serialization
branch
from
ef0b0f5 to
55edf7e
Compare
May 5, 2023 20:21
timea-solid
approved these changes
May 8, 2023
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I confirm this is working.
Fixed the failing e2e tests too.
Sorry, something went wrong.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At present, the access grant library uses the default serialization of java.time.Instant, which results in a long, which is not supported by a VC-API endpoint. Instead, the value needs to be serialized as an ISO-8601 string.
In addition, the revocation method uses the status list identifier rather than the access grant identifier, which also causes an error.