JCL-340: Pluralize getter names in WebIdProfile class - #449
Merged
acoburn merged 1 commit intoMay 15, 2023
Merged
acoburn merged 1 commit into
acoburn merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
timea-solid
approved these changes
May 15, 2023
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deprecates the existing (singular) getter methods on the WebIdProfile class, replacing them with plural equivalents.
The one method that didn't have an obvious plural was getSeeAlso, which I replaced with getRelatedResources. I am not wedded to that name, if someone comes up with a better one.
Also, it appeared that there was insufficient testing of this class, so I added complete testing of the WebIdProfile class.