JCL-366: Remove use of deprecated authenticate - #489
Merged
acoburn merged 2 commits intoMay 26, 2023
Merged
acoburn merged 2 commits into
acoburn merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
NSeydoux
approved these changes
May 26, 2023
acoburn
enabled auto-merge (squash)
May 26, 2023 10:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Session.authenticate(Request, Set<String>) method was deprecated as part of #459.
In that change, the ReactiveAuthorization class calls session.authenticate(Authenticator, Request, Set<String>) so that the session is able to manage a token cache internally.
As such, the session may call the Authenticator object to retrieve the relevant credential. If that authenticator also calls session.authenticate(...) -- as it does here -- there is a possibility that this call will enter a recursive loop.
This PR removes the use of the deprecated Session.authenticate(Request, Set<String>) method as it is no longer needed for reactive authorization. Instead, the authenticator only extracts an OpenID Credential from the existing session.